Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfoming force #863

Merged
merged 3 commits into from
Feb 27, 2021
Merged

Transfoming force #863

merged 3 commits into from
Feb 27, 2021

Conversation

Anton-Latukha
Copy link
Collaborator

@Anton-Latukha Anton-Latukha commented Feb 26, 2021

Depends on (so the list contains) #862, please review the #850. first.

Is another milestone towards: #850.

Now fruits are starting to show.

The chain of functions still passively passes-through the functional arguments,
and do nothing with them at the end.

Lets stop that practice in the code.

Factoring-out the function passing from the functions - allows to just apply the
previously passed function exteriorly.

Which siplifies the implementation, code reads and understands better, functions
specialize on what they do, so GHC can optimize them better.

This actively shows the refactoring practice.

M  src/Nix/Cited/Basic.hs
M  src/Nix/Convert.hs
M  src/Nix/Lint.hs
M  src/Nix/Normal.hs
M  src/Nix/Standard.hs
M  src/Nix/Thunk.hs
M  src/Nix/Thunk/Basic.hs
M  src/Nix/Type/Infer.hs
M  src/Nix/Value.hs
M  src/Nix/Value/Equal.hs
@Anton-Latukha Anton-Latukha force-pushed the 2021-02-26-transfoming-force branch from 556dd9b to 76a3f87 Compare February 27, 2021 15:24
@Anton-Latukha Anton-Latukha merged commit 251fe88 into master Feb 27, 2021
@Anton-Latukha Anton-Latukha deleted the 2021-02-26-transfoming-force branch February 27, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant